Fixes #1994 #4874
Closed
Fixes #1994 #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So in what way #4871 is fixed? Any chance to note that in |
|
I think this implementation is convoluted. Internally opcGorge can be changed to opcGorgeEx and a wrapper gorge can call gorgeEx. I'm also not too happy with this |
|
@Araq: I had problems determining which proc was called without splitting What would you prefer as name for the extended procs? |
* moved common opcGorge[Ex] code to template * renamed opGorge to opGorgeEx * splitted opcGorge / opcGorgeEx implementations
Araq
added a commit
that referenced
this pull request
Jan 7, 2017
|
Implemented it differently. Read and learn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
gorgeExandstaticReadExwhich both return a tuple of output and result code. Furthermore, it add an optional parameteronErrorBreaktogorgeandstaticRead, because that was cheap to add when implementinggorgeExfunctionality.staticReadExandgorgeExwill still break if executing the command raises anOSError.This PR includes #4872.